Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Saved filter key shortcuts: lowercase letters have shift modifier added #3998

Closed
svobs opened this issue Oct 16, 2022 · 0 comments · Fixed by #3999
Closed

Saved filter key shortcuts: lowercase letters have shift modifier added #3998

svobs opened this issue Oct 16, 2022 · 0 comments · Fixed by #3999

Comments

@svobs
Copy link
Contributor

svobs commented Oct 16, 2022

Screen Shot 2022-10-16 at 15 07 08

System and IINA version:

  • macOS 12.6
  • IINA 1.3.0 develop branch, commit 6da6a3f

Expected behavior:
If a saved filter has a key equivalent, it should only include Shift if the user specified it.

Actual behavior:
When a filter is saved, theShift modifier is added for both lowercase and uppercase letters.

Steps to reproduce:

  1. Pick a lowercase letter which is easy to distinguish from its uppercase variant, like 't', and make sure you haven't already assigned it to a keybinding in the Preferences > Key Bindings table.
  2. From the Video menu, select Video Filters...
  3. Click the + button to create a new filter. A new dialog should open with options.
  4. Leave Crop selected on the left. On the right, enter 200 for Width, and 200 for Height, and leave Origin X & Origin Y empty. Click Add.
  5. The dialog should close, and the new filter should appear in the list, with a Save button. Click `Save'.
  6. Enter a name for the new filter, like "Custom Crop", then click the blank area under Shortcut Key:. Type 't' (or your chosen lowercase key). It should appear in the box in uppercase. Click Add.
  7. The filter should now appear in the list under Saved filters.
  8. Now go back to the Video menu, and hover over Saved Video Filters. See that the key will appear with a shift symbol in front of it.
  9. Open a video and type the lowercase letter. See that IINA beeps at you. Type it again holding down Shift. See that the filter is activated and the video is cropped.

How often does this happen?
Always, given that the key is a letter which can have an uppercase form.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants