You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Expected behavior:
If a saved filter has a key equivalent, it should only include Shift if the user specified it.
Actual behavior:
When a filter is saved, theShift modifier is added for both lowercase and uppercase letters.
Steps to reproduce:
Pick a lowercase letter which is easy to distinguish from its uppercase variant, like 't', and make sure you haven't already assigned it to a keybinding in the Preferences > Key Bindings table.
From the Video menu, select Video Filters...
Click the + button to create a new filter. A new dialog should open with options.
Leave Crop selected on the left. On the right, enter 200 for Width, and 200 for Height, and leave Origin X & Origin Y empty. Click Add.
The dialog should close, and the new filter should appear in the list, with a Save button. Click `Save'.
Enter a name for the new filter, like "Custom Crop", then click the blank area under Shortcut Key:. Type 't' (or your chosen lowercase key). It should appear in the box in uppercase. Click Add.
The filter should now appear in the list under Saved filters.
Now go back to the Video menu, and hover over Saved Video Filters. See that the key will appear with a shift symbol in front of it.
Open a video and type the lowercase letter. See that IINA beeps at you. Type it again holding down Shift. See that the filter is activated and the video is cropped.
How often does this happen?
Always, given that the key is a letter which can have an uppercase form.
The text was updated successfully, but these errors were encountered:
System and IINA version:
Expected behavior:
If a saved filter has a key equivalent, it should only include
Shift
if the user specified it.Actual behavior:
When a filter is saved, the
Shift
modifier is added for both lowercase and uppercase letters.Steps to reproduce:
Video
menu, selectVideo Filters...
+
button to create a new filter. A new dialog should open with options.Crop
selected on the left. On the right, enter 200 for Width, and 200 for Height, and leave Origin X & Origin Y empty. ClickAdd
.Save
button. Click `Save'.Shortcut Key:
. Type 't' (or your chosen lowercase key). It should appear in the box in uppercase. Click Add.Saved filters
.Video
menu, and hover overSaved Video Filters
. See that the key will appear with a shift symbol in front of it.Shift
. See that the filter is activated and the video is cropped.How often does this happen?
Always, given that the key is a letter which can have an uppercase form.
The text was updated successfully, but these errors were encountered: