UX improvements to the “Jump to…” command #4084
Conversation
| @@ -124,7 +124,7 @@ extension MainMenuActionHandler { | |||
| } | |||
|
|
|||
| @objc func menuJumpTo(_ sender: NSMenuItem) { | |||
| Utility.quickPromptPanel("jump_to") { input in | |||
| Utility.quickPromptPanel("jump_to", inputValue: self.player.info.videoPosition?.stringRepresentationWithPrecision(3)) { input in | |||
There was a problem hiding this comment.
3 sub-second digits is the highest precision selectable in the UI (and commonly used in video editing). I think it’s a good default. Alternatively, we could use the precision the user has previously chosen to be displayed in the player controls.
iina/VideoTime.swift
Outdated
| } else { | ||
| return nil | ||
| } | ||
| let split = Array(format.split(separator: ":").map { String($0) }.reversed()) |
There was a problem hiding this comment.
Probably the new regex builder would be cool to use for parsing but I gather it’s only available with newer versions of swift.
sabberworm
changed the title
sabberworm
changed the title
|
Is there anything I can do to improve the chances of this getting merged? This feature would have been helpful to me numerous times in the past year. |
|
I pulled and tested this fix, and it looks good to me. Unfortunately I can't do anything to get it merged, so 🤞 |
sabberworm
force-pushed
the
feature/ux-improvements-for-time-jump
branch
2 times, most recently
from
534ecba
to
4514d99
Compare
@sabberworm Thanks for your contribution. Noted this PR in the backlog. Will merge this before the next beta version. |
sabberworm
force-pushed
the
feature/ux-improvements-for-time-jump
branch
from
4514d99
to
74ccc1c
Compare
| @@ -124,7 +124,7 @@ extension MainMenuActionHandler { | |||
| } | |||
|
|
|||
| @objc func menuJumpTo(_ sender: NSMenuItem) { | |||
| Utility.quickPromptPanel("jump_to") { input in | |||
| Utility.quickPromptPanel("jump_to", inputValue: self.player.info.videoPosition?.stringRepresentationWithPrecision(3)) { input in | |||
Co-authored-by: Yuze Jiang <i@uiryuu.moe>
This PR adds small UX improvements to the Playback → Jump to… command:
Initially I had wanted a quick way to copy the current time code. I was already starting to implement a dedicated command for that when I realized the same could be accomplished more synergistically by beefing up the existing “Jump to…” command.
Will also fix #4547