Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subtitles panel shows "..." for subtitle number #4341

Closed
1 task done
low-batt opened this issue Apr 10, 2023 · 3 comments · Fixed by #4377
Closed
1 task done

Subtitles panel shows "..." for subtitle number #4341

low-batt opened this issue Apr 10, 2023 · 3 comments · Fixed by #4377

Comments

@low-batt
Copy link
Contributor

System and IINA version:

  • macOS 13.3.1
  • IINA develop branch

Expected behavior:
The subtitles panel is able to properly display the subtitle number for more than 9 subtitle files.

Actual behavior:
The subtitles panel displays #9 for the ninth subtitle file, but only ... for the 10th subtitle file. The panel should at least be able to accommodate 2 digits. Also when the panel first opens it displays the subtitle files starting with <none>, even if subtitle #8 is selected, forcing the user to scroll to see the selected subtitle file.

missing-subtitle-number

Steps to reproduce:
Play a video with many subtitle files. Open the subtitles panel. Scroll down past the ninth subtitle file.

  • MPV does not have this problem.

How often does this happen?
Every time.

@svobs
Copy link
Contributor

svobs commented Apr 11, 2023

I can take a look this one. May be a good idea to revisit Video track, Audio track, and Secondary sub tables too.

@low-batt
Copy link
Contributor Author

Yes. Secondary sub definitely exhibits this problem as well. I did not check the other tables. Instead of subtitles a video might have a number of different audio tracks.

@low-batt
Copy link
Contributor Author

low-batt commented Jan 2, 2024

This is fixed in the released version of IINA.

@low-batt low-batt closed this as completed Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants