Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix giant Sonoma egg in Subtitles sidebar (bug #4638) #4640

Merged
merged 1 commit into from Oct 6, 2023
Merged

Fix giant Sonoma egg in Subtitles sidebar (bug #4638) #4640

merged 1 commit into from Oct 6, 2023

Conversation

svobs
Copy link
Contributor

@svobs svobs commented Oct 6, 2023

Description:
Changes code to use bounds instead of dirtyRect, which should be much more reliable, and gets rid of the egg.

@svobs svobs changed the title Fix giant egg which showed up in Subtitles sidebar in MacOS 14.0 Sonoma Fix giant Sonoma egg in Subtitles sidebar (bug #4638) Oct 6, 2023
@low-batt low-batt linked an issue Oct 6, 2023 that may be closed by this pull request
Giant unwanted Easter egg in Subtitles sidebar #4638
Closed
1 task
low-batt
low-batt approved these changes Oct 6, 2023
View reviewed changes
Copy link
Contributor

@low-batt low-batt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pulled PR, built IINA and tested under macOS 13.5.2 and 10.15.7.
Changes look good to me.

@low-batt low-batt merged commit 2ec4e36 into iina:develop Oct 6, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@low-batt low-batt low-batt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Giant unwanted Easter egg in Subtitles sidebar
2 participants
@svobs @low-batt