Fix Open Recent menu cleared with each new build, #4688 #4730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit will:
- Add a recentDocuments setting to Preference
- Add the method saveRecentDocuments to AppDelegate
- Add a call to saveRecentDocuments in:
- AppDelegate.openFile
- PlayerCore.fileLoaded
- PrefGeneralViewController.rememberRecentChanged
- PrefUtilsViewController.clearHistoryBtnAction
- Add the method restoreRecentDocuments to AppDelegate
- Add a call to restoreRecentDocuments in
AppDelegate.applicationWillFinishLaunching
Other than the adding the recentDocuments preference, all changes are
only included in debug builds as this is a workaround that is only
intended to provide a better experience for developers.
The workaround saves the list of recently opened files as an IINA
setting so that the list can be restored when sharedfilelistd clears
the list due to the ad hoc certificate used in developer builds.
1 task
1 task
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit will:
recentDocumentssetting toPreferencesaveRecentDocumentstoAppDelegatesaveRecentDocumentsin:AppDelegate.openFilePlayerCore.fileLoadedPrefGeneralViewController.rememberRecentChangedPrefUtilsViewController.clearHistoryBtnActionrestoreRecentDocumentstoAppDelegaterestoreRecentDocumentsinAppDelegate.applicationWillFinishLaunchingOther than the adding the
recentDocumentspreference, all changes are only included in debug builds as this is a workaround that is only intended to provide a better experience for developers.The workaround saves the list of recently opened files as an IINA setting so that the list can be restored when
sharedfilelistdclears the list due to the ad hoc certificate used in developer builds.Description: