Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On screen display not displaying correct time after seek action, and seek action not applying the correct time. #4804

Open
RowanDabron opened this issue Feb 3, 2024 · 3 comments

Comments

@RowanDabron
Copy link

IINA v1.3.4 Build 140
macOS
Monterey v12.2.1

I have the keybindings set so control+command+left or right arrow key seek backwards 3s or forwards 3s respectively, but the behaviour is rarely correct, it consistently skips 10s (as far as the video and on screen controller are concerned), and the on screen display shows a different time to that of the OSC.
Starting from OSD, OSC, and video all being in sync and correct, the first instance of seek skips the video and OSC 10 seconds, but the OSD skips 3s (in the correct direction), on the second instance the OSC and video skip 10s again and the OSD skips 10 seconds from it's previous incorrect time and so is still out of sync with the OSC and video.
It is possible to get the OSD to skip in the opposite direction to the intended behaviour, the OSC and video. This happens when I try to skip forward 3s twice and backwards 3s once (⌃⌘→ + ⌃⌘→ + ⌃⌘←), the OSC and video skips forward 10s twice, and backwards 10s once, but the OSD skips forwards 3s, forwards 10s, then forwards 5s.

Additionally the OSD time does not update as the video is playing, which may be intended behaviour since it is usually only on screen for a very short duration (I have set it to stay on longer to observe the above issue), but it would be nice if it could update continuously as the video plays, but that is a very minor nitpick for me.

I have attached some screenshots showing the OSD being out of sync with the OSC.

Screen Shot 2024-02-04 at 09 23 33 Screen Shot 2024-02-04 at 09 23 43 Screen Shot 2024-02-04 at 09 23 59
@HarukaMa HarukaMa transferred this issue from iina/iina-website Feb 3, 2024
@HarukaMa
Copy link
Member

HarukaMa commented Feb 3, 2024

You might want to see #4766 for the inexact seek part.

@RowanDabron
Copy link
Author

Thank you very much, that explains that part.

Am I correct in thinking the out of sync OSD and OSC are still a valid issue or should this be closed?

@low-batt
Copy link
Contributor

low-batt commented Feb 4, 2024

Please leave this issue open for now. I'm uncertain as to whether the OSD behavior is the same as issue #4779 or not. There is definitely some OSD behavior that needs to be addressed.

As you can see from the comments on issue #4766 that @HarukaMa referenced we are debating changing the default seeking behavior to be exact even though that is slower because the current behavior is unexpected and confusing.

Thank you for entering such a clear and detailed report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants