Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use sub-second progress bar step size #49

Closed
angli232 opened this issue Jan 6, 2017 · 3 comments
Closed

use sub-second progress bar step size #49

angli232 opened this issue Jan 6, 2017 · 3 comments

Comments

@angli232
Copy link
Contributor

angli232 commented Jan 6, 2017

The current step size of the progress bar is one second. However, it may not be good enough in the case of short videos with a total duration of only a few seconds. In that case, the indicator jumps too much each time and it is not possible to slide the progress bar to a non-integer time point.

I am working on a fix and will send a pull request after some more testing.

@lhc70000
Copy link
Member

lhc70000 commented Jan 6, 2017

Thanks a lot!

I'm afraid that currently VideoTime.swift only works for integer seconds. So there may be a lot of works to do. Please update here if you have any problem.

@angli232
Copy link
Contributor Author

angli232 commented Jan 6, 2017

Luckily time-pos could be get as double with the higher resolution, so the fix was not complicated. I am not familiar with Swift, so I hope I did not break other things with the changes.

@angli232
Copy link
Contributor Author

angli232 commented Jan 8, 2017

Fixed by 63bf466.

@angli232 angli232 closed this as completed Jan 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants