Consider using Leaflet.Tooltip

[johnd0e]

Since Leaflet 1.0 there is buildin L.Tooltip functionality, which can be more powerful than IITC's own custom tooltips.

For example, it could be used in player-tracker in order to provide (optionally) permanent labels for players' nicks.

I saw some plugins capable of that, but their implementations are far from perfect (main issue: overlapping labels).

Some ideas where we may use tooltips:

• Portal info tooltip Portal tooltip #195
• Portal permanent label (as replacement for portal-names plugin)
• Players' nicks for player-tracker

[johnd0e]

For example, it could be used in player-tracker in order to provide (optionally) permanent labels for players' nicks.

player-tracker code is not great. E.g. this part currently seems do nothing:

ingress-intel-total-conversion/plugins/player-activity-tracker.user.js

Lines 50 to 55 in 256f9c5

	if(obj.layer === plugin.playerTracker.drawnTracesEnl || obj.layer === plugin.playerTracker.drawnTracesRes) {
	obj.layer.eachLayer(function(marker) {
	if(marker._icon) window.setupTooltips($(marker._icon));
	});
	}
	});

Similar code is here

ingress-intel-total-conversion/plugins/player-activity-tracker.user.js

Lines 404 to 407 in 256f9c5

	// jQueryUI doesn’t automatically notice the new markers
	if (!isTouchDev) {
	window.setupTooltips($(m._icon));
	}

And here and there I see workaround if form of force calling closeIconTooltips

ingress-intel-total-conversion/plugins/player-activity-tracker.user.js

Lines 81 to 89 in 256f9c5

	// force close all open tooltips before markers are cleared
	window.plugin.playerTracker.closeIconTooltips = function() {
	plugin.playerTracker.drawnTracesRes.eachLayer(function(layer) {
	if ($(layer._icon)) { $(layer._icon).tooltip('close');}
	});
	plugin.playerTracker.drawnTracesEnl.eachLayer(function(layer) {
	if ($(layer._icon)) { $(layer._icon).tooltip('close');}
	});
	}

I suppose that using leaflet native tooltips instead of jQueryUI would be much easier and do not require any special handling, we just need bindTooltip here:

ingress-intel-total-conversion/plugins/player-activity-tracker.user.js

Line 389 in 256f9c5

var m = L.marker(gllfe(last), {icon: icon, referenceToPortal: closestPortal, opacity: absOpacity, desc: popup[0], title: tooltip});

But as for initial intention (bindTooltip with permanent: true option on every marker) then we should consider to apply special tooltips styling (default is not good for dense areas).

[johnd0e]

Also we could use tooltips with portal markers, to display title if available (or some other info in concise form).

To avoid tooltip overlapping: https://github.com/ZijingPeng/leaflet-tooltip-layout

[Gollam]

Hi @modos189, I just had the idea of showing agent names in player tracker, and I found this open issue. Do you think I should try to write some code for it?

[DanielOndiordna]

My player tracker add-on plugin already adds permanent player names as labels to the markers.
https://softspot.nl/ingress/plugindetails/iitc-plugin-player-tracker-addon
This plugin adds Leaflet.iconlabel:
https://github.com/jacobtoye/Leaflet.iconlabel

[Gollam]

@DanielOndiordna thanks! I still think this would be a useful optional feature to contribute into the official plugin :) also I think it would be useful to display the machina movement (e.g. with white icon), also optionally.

[xscreach]

@DanielOndiordna thanks! I still think this would be a useful optional feature to contribute into the official plugin :) also I think it would be useful to display the machina movement (e.g. with white icon), also optionally.

Imho a good idea 👍
Just note that Machina movement is handled by machina-tracker plugin 😉

[Gollam]

@xscreach thanks! I'll check it.