Resolve notation and consistency

euro-hpc-pl · Oct 18, 2020 · c4258b5 · c4258b5 · bartekGardas · Oct 20, 2020
1 parent 80ccefb
commit c4258b5
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 8 deletions.
diff --git a/src/base.jl b/src/base.jl
@@ -33,7 +33,7 @@ for (T, N) in ((:MPO, 4), (:MPS, 3))
     end
 end
 
-function MPO(ψ::MPS{T}) where {T <: AbstractArray{<:Number, 3}}
+function MPO(ψ::MPS{T}) where {T}
     _verify_square(ψ)
     L = length(ψ)
     O = MPO(T.name.wrapper, eltype(T), L)
@@ -48,7 +48,7 @@ function MPO(ψ::MPS{T}) where {T <: AbstractArray{<:Number, 3}}
     O
 end 
 
-function MPS(O::MPO{T}) where T <: AbstractArray{<:Number, 4}
+function MPS(O::MPO{T}) where {T}
     L = length(O)
     ψ = MPS(T.name.wrapper, eltype(T), L)
 
@@ -71,7 +71,7 @@ function Base.randn(::Type{MPS{T}}, L::Int, D::Int, d::Int) where {T}
     ψ
 end
 
-function Base.randn(::Type{MPO{T}}, L::Int, D::Int, d::Int) where T <: AbstractArray{<:Number, 4}
+function Base.randn(::Type{MPO{T}}, L::Int, D::Int, d::Int) where {T}
     S = newdim(T, 3)
     ψ = randn(MPS{S}, L, D, d^2) 
     MPO(ψ)

diff --git a/src/contractions.jl b/src/contractions.jl
@@ -1,5 +1,5 @@
 
-export dot, norm, left_env
+export left_env
 
 function LinearAlgebra.dot(ϕ::MPS, ψ::MPS)
     C = ones(eltype(ψ), 1, 1)
@@ -32,9 +32,9 @@ end
 
 LinearAlgebra.norm(ψ::MPS) = sqrt(abs(dot(ψ, ψ)))
 
-function LinearAlgebra.dot(ϕ::MPS, O::Vector{S}, ψ::MPS) where {S <: AbstractMatrix}
-    R = eltype(ψ)
-    C = ones(R, 1, 1)
+function LinearAlgebra.dot(ϕ::MPS, O::Vector{T}, ψ::MPS) where {T <: AbstractMatrix}
+    S = eltype(ψ)
+    C = ones(S, 1, 1)
 
     for i ∈ 1:length(ψ)
         M = ψ[i]
@@ -61,7 +61,7 @@ end
 
 Base.:(*)(O::MPO, ψ::MPS) = return dot(O, ψ)
 
-function LinearAlgebra.dot(O1::MPO{T}, O2::MPO{T}) where T <: AbstractArray{<:Number, 4}
+function LinearAlgebra.dot(O1::MPO{T}, O2::MPO{T}) where {T}
     L = length(O1)
     tensors = Vector{T}(undef, L)