Bg/refactoring #11
Merged
Bg/refactoring #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please stop commiting the |
lpawela
requested changes
Nov 24, 2020
There was a problem hiding this comment.
Some tests fail
Exact Gibbs pure state (MPS): Test Failed at /home/lpawela/new-zksi-repo/SpinGlassPEPS.jl/test/search.jl:145
Expression: maximum(prob) > pCut
Evaluated: 0.008630836041790024 > 0.3315484059638665This seems to be somehow probabilistic, for a total of 3 test runs I got this error only once.
lpawela
approved these changes
Nov 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ready to merge. Support for arbitrary rank tensors has been added, small bugs have been fixed.