Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

surface is inconsistent with Bézier spline #33

Closed
ijlyttle opened this issue Oct 9, 2020 · 2 comments
Closed

surface is inconsistent with Bézier spline #33

ijlyttle opened this issue Oct 9, 2020 · 2 comments

Comments

@ijlyttle
Copy link
Owner

ijlyttle commented Oct 9, 2020

Although the control points are constrained to a surface, the Bézier spline is not.

This results in an inconsistency (note the max chroma):

image

image

@ijlyttle
Copy link
Owner Author

ijlyttle commented Oct 9, 2020

I don't know if this is a real problem or not.

If we wanted to constrain the spline to the surface, we could - but we would lose the Euclidean-distance rescaling that we get "free" as a part of the spline.

We could write our own rescaler, based on farver::compare_color(), but that might be a bit much.

@ijlyttle
Copy link
Owner Author

solved in #51

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant