Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nested createSharedElementStackNavigator()'s don't work #6

Closed
anfen opened this issue Nov 11, 2019 · 6 comments
Closed

Nested createSharedElementStackNavigator()'s don't work #6

anfen opened this issue Nov 11, 2019 · 6 comments
Labels
bug Something isn't working

Comments

@anfen
Copy link

anfen commented Nov 11, 2019

I'm not sure if this is supposed to be possible, but would be great if so

@IjzerenHein
Copy link
Owner

Yes, we should be able to get that to work. Thanks for the reminder :)

@IjzerenHein IjzerenHein added the bug Something isn't working label Nov 12, 2019
@sa8ab
Copy link

sa8ab commented Jan 17, 2020

What suggestion do you have on solving this issue before you update the lib?
Can we make shared element stack as top level?

@IjzerenHein
Copy link
Owner

I don't have a suggestion tbh. In this case it's just a matter of having a reproducible case and diving in the code and debugging where it goes wrong. If you want to help, having a very simple example that reproduces the problem would be helpful.

@IjzerenHein
Copy link
Owner

Hi. I've begun work on v2 of this lib, which will work with react-navigation-stack@2. I have nested navigators working in that version. If you are interested in testing, please take a look here:
https://github.com/IjzerenHein/react-navigation-shared-element/blob/master/README_v2.md

@IjzerenHein
Copy link
Owner

Support for stack v2 and nested navigators has been released.
https://github.com/IjzerenHein/react-navigation-shared-element/releases/tag/v2.0.1

Let me know whether this fixes the problem for you.

@IjzerenHein
Copy link
Owner

Closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants