Use system version of libfmt instead of rosfmt vendored one on ROS 1 #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Including this package on a ROS Noetic setup where other packages use system
libfmt-devcauses xqms/rosfmt#12 to break them.We're dropping mqtt from our setup for different reasons, so this isn't exhaustively tested. But in case it helps, these changes drop
rosfmtin favor of systemlibfmt-devand the package still builds on Noetic, which is the only version this is released into. A simple test run of the nodelet also seems to format error messages just fine.