Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Could you help using some open source license such as MIT or GPL? #46

Closed
cxwx opened this issue Jul 6, 2020 · 3 comments
Closed

Could you help using some open source license such as MIT or GPL? #46

cxwx opened this issue Jul 6, 2020 · 3 comments

Comments

@cxwx
Copy link

cxwx commented Jul 6, 2020

I'd love to add it to homebrew
https://github.com/Homebrew/homebrew-core/pull/57549.
But it has an license error

@ikalnytskyi
Copy link
Owner

Hey @cxwx! Can you please elaborate on a license error? termcolor is licensed under BSD 3-clause License. It's an open source license and a lot of projects are using it.

@ikalnytskyi
Copy link
Owner

Ok, I checked the error message in your PR.

image

It seems like a license is not specified for the package. I assume that normally they have some sort of heuristic or something in Homebrew to autodetect the license based on LICENSE content. Due to some issue, though, they failed to do so. I bet if you explicitly specify the license in Homebrew's formula everything should be fine.

Example:

https://github.com/Homebrew/homebrew-core/blob/6a8f5692ae05d70f347ce194d9cd892370712239/Formula/udptunnel.rb#L7

@cxwx
Copy link
Author

cxwx commented Jul 7, 2020

OK, thanks

@cxwx cxwx closed this as completed Jul 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants