WAPM publishing #31
Open
WAPM publishing #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Actually, can I ask you to wait with merging this for a bit? It might be necessary to downgrade rust to 1.56 for the release build because of this bug. |
|
OK, please notify me after the bug is fixed. |
ikanago
requested changes
May 27, 2022
| @@ -38,31 +39,33 @@ jobs: | |||
| echo "PROJECT_VERSION=${GITHUB_REF#refs/tags/v}" >> "$GITHUB_ENV" | |||
| echo "Version: ${{ env.PROJECT_VERSION }}" | |||
|
|
|||
| - name: Check git tag against toml values | |||
| if: ${{ matrix.job.os != 'windows-2019' }} # windows too weird | |||
There was a problem hiding this comment.
These files are identical among jobs, so just checking on one job, ubuntu-20.04 for example, is enough.
There was a problem hiding this comment.
That is what I thought at first, too, but tell me: Won't the publish step for the other os still run, creating a release with some missing files?
omekasy/.github/workflows/release.yml
Lines 89 to 95 in a36cd66
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements wasmerio/wasmer#29.
I've tested this on some other repository, but I obviously can't test it on yours. So there might be some quirks.
For the login token, you'll have to:
And then register that as a new repository secret on this github repo.