Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeScript 5.0 support? #414

Closed
karlhorky opened this issue Apr 3, 2023 · 1 comment Β· Fixed by #415
Closed

TypeScript 5.0 support? #414

karlhorky opened this issue Apr 3, 2023 · 1 comment Β· Fixed by #415

Comments

@karlhorky
Copy link
Contributor

karlhorky commented Apr 3, 2023

Hi @ikatyang πŸ‘‹ Hope you are well.

I upgraded to TypeScript 5.0.3 recently, and noticed that the tests using dts-jest are now failing:

FAIL dts src/__tests__/dts-jest/003-literals-unions.test.ts
  ● Test suite failed to run

    TypeError: ts.getMutableClone is not a function

      at substituteNode (node_modules/dts-jest/lib/utils/get-node-one-line-text.js:8:34)
      at getPipelinePhase (node_modules/typescript/lib/typescript.js:110287:76)
      at pipelineEmit (node_modules/typescript/lib/typescript.js:110270:29)
      at print (node_modules/typescript/lib/typescript.js:110184:7)
      at writeNode (node_modules/typescript/lib/typescript.js:110027:7)
      at Object.printNode (node_modules/typescript/lib/typescript.js:109991:7)
      at get_node_one_line_text (node_modules/dts-jest/lib/utils/get-node-one-line-text.js:21:10)
      at node_modules/dts-jest/lib/utils/find-trigger-bodies.js:44:77
      at traverse_node (node_modules/dts-jest/lib/utils/traverse-node.js:6:9)
      at node_modules/dts-jest/lib/utils/traverse-node.js:8:79
      at visitNodes (node_modules/typescript/lib/typescript.js:27[58](https://github.com/upleveled/courses/actions/runs/4590799480/jobs/8106576734?pr=1621#step:18:59)8:24)
      at forEachChildInBlock (node_modules/typescript/lib/typescript.js:27[63](https://github.com/upleveled/courses/actions/runs/4590799480/jobs/8106576734?pr=1621#step:18:64)3:12)
      at Object.forEachChild (node_modules/typescript/lib/typescript.js:27673:37)
      at traverse_node (node_modules/dts-jest/lib/utils/traverse-node.js:8:8)
      at node_modules/dts-jest/lib/utils/traverse-node.js:8:79
      at visitNode2 (node_modules/typescript/lib/typescript.js:27580:20)
      at forEachChildInArrowFunction (node_modules/typescript/lib/typescript.js:28087:249)
      at Object.forEachChild (node_modules/typescript/lib/typescript.js:27673:37)
      at traverse_node (node_modules/dts-jest/lib/utils/traverse-node.js:8:8)
      at node_modules/dts-jest/lib/utils/traverse-node.js:8:79
      at visitNodes (node_modules/typescript/lib/typescript.js:27588:24)
      at forEachChildInCallOrNewExpression (node_modules/typescript/lib/typescript.js:27630:101)
      at Object.forEachChild (node_modules/typescript/lib/typescript.js:27673:37)
      at traverse_node (node_modules/dts-jest/lib/utils/traverse-node.js:8:8)
      at node_modules/dts-jest/lib/utils/traverse-node.js:8:79
      at visitNode2 (node_modules/typescript/lib/typescript.js:27580:20)
      at forEachChildInExpressionStatement (node_modules/typescript/lib/typescript.js:28217:18)
      at Object.forEachChild (node_modules/typescript/lib/typescript.js:27673:37)
      at traverse_node (node_modules/dts-jest/lib/utils/traverse-node.js:8:8)
      at node_modules/dts-jest/lib/utils/traverse-node.js:8:79
      at visitNodes (node_modules/typescript/lib/typescript.js:27588:24)
      at forEachChildInSourceFile (node_modules/typescript/lib/typescript.js:28208:18)
      at Object.forEachChild (node_modules/typescript/lib/typescript.js:27673:37)
      at traverse_node (node_modules/dts-jest/lib/utils/traverse-node.js:8:8)
      at find_trigger_bodies (node_modules/dts-jest/lib/utils/find-trigger-bodies.js:16:39)
      at find_triggers (node_modules/dts-jest/lib/utils/find-triggers.js:11:[64](https://github.com/upleveled/courses/actions/runs/4590799480/jobs/8106576734?pr=1621#step:18:65))
      at Object.transform [as process] (node_modules/dts-jest/lib/transform.js:21:54)
      at ScriptTransformer.transformSource (node_modules/@jest/transform/build/ScriptTransformer.js:542:31)
      at ScriptTransformer._transformAndBuildScript (node_modules/@jest/transform/build/ScriptTransformer.js:[67](https://github.com/upleveled/courses/actions/runs/4590799480/jobs/8106576734?pr=1621#step:18:68)1:40)
      at ScriptTransformer.transform (node_modules/@jest/transform/build/ScriptTransformer.js:[72](https://github.com/upleveled/courses/actions/runs/4590799480/jobs/8106576734?pr=1621#step:18:73)3:19)

What do you think about adding TypeScript 5.0 support?

@karlhorky
Copy link
Contributor Author

Thanks for the quick PR @ikatyang ! Can confirm that dts-jest@26.0.0 works with typescript@5.0.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants