fix: ngMocks.guts reuses mock pipes

closes #241

lib/common/ng-mocks-universe.ts

@@ -6,6 +6,19 @@ import { AnyType } from './core.types';
 // istanbul ignore next
 const getGlobal = (): any => window || global;
 
+interface NgMocksUniverse {
+  builtDeclarations: Map<any, any>;
+  builtProviders: Map<any, any>;
+  cacheDeclarations: Map<any, any>;
+  cacheProviders: Map<any, any>;
+  config: Map<any, any>;
+  flags: Set<string>;
+  global: Map<any, any>;
+  isExcludedDef: (def: any) => boolean;
+  isProvidedDef: (def: any) => boolean;
+  touches: Set<AnyType<any> | InjectionToken<any> | string>;
+}
+
 getGlobal().ngMocksUniverse = getGlobal().ngMocksUniverse || {
   builtDeclarations: new Map(),
   builtProviders: new Map(),
@@ -29,4 +42,4 @@ getGlobal().ngMocksUniverse = getGlobal().ngMocksUniverse || {
  *
  * @internal
  */
-export default (() => getGlobal().ngMocksUniverse)();
+export default ((): NgMocksUniverse => getGlobal().ngMocksUniverse)();

lib/mock-builder/mock-builder-stash.ts

@@ -26,7 +26,7 @@ export class MockBuilderStash {
 
   public restore(): void {
     for (const key of Object.keys(this.data)) {
-      ngMocksUniverse[key] = (this.data as any)[key];
+      (ngMocksUniverse as any)[key] = (this.data as any)[key];
     }
   }
 }

lib/mock-helper/mock-helper.guts.ts

@@ -145,16 +145,18 @@ const resolve = (data: Data, def: any, skipDestruction = true): void => {
   }
 };
 
+const generateData = (keep: any, mock: any, exclude: any): Data => ({
+  declarations: [],
+  exclude: new Set(flatten(exclude || [])),
+  imports: [],
+  keep: new Set(flatten(keep || [])),
+  mock: new Set(flatten(mock || [])),
+  providers: [],
+  skip: new Set(),
+});
+
 export default (keep: any, mock: any = null, exclude: any = null): TestModuleMetadata => {
-  const data: Data = {
-    declarations: [],
-    exclude: new Set(flatten(exclude || [])),
-    imports: [],
-    keep: new Set(flatten(keep || [])),
-    mock: new Set(flatten(mock || [])),
-    providers: [],
-    skip: new Set(),
-  };
+  const data: Data = generateData(keep, mock, exclude);
 
   for (const def of mapValues(data.mock)) {
     resolve(data, def, false);

lib/mock-module/mock-ng-def.ts

@@ -42,26 +42,38 @@ const flatToExisting = <T, R>(data: T | T[], callback: (arg: T) => R | undefined
 
 type processMeta = 'declarations' | 'entryComponents' | 'bootstrap' | 'providers' | 'imports' | 'exports';
 
+const configureProcessMetaKeys = (
+  resolve: (def: any) => any,
+  resolveProvider: (def: Provider) => any,
+): Array<[processMeta, (def: any) => any]> => [
+  ['declarations', resolve],
+  ['entryComponents', resolve],
+  ['bootstrap', resolve],
+  ['providers', resolveProvider],
+  ['imports', resolve],
+  ['exports', resolve],
+];
+
 const processMeta = (
   ngModule: NgModule,
   resolve: (def: any) => any,
   resolveProvider: (def: Provider) => any,
 ): NgModule => {
   const mockModuleDef: NgModule = {};
+  const keys = configureProcessMetaKeys(resolve, resolveProvider);
 
-  const keys: Array<[processMeta, (def: any) => any]> = [
-    ['declarations', resolve],
-    ['entryComponents', resolve],
-    ['bootstrap', resolve],
-    ['providers', resolveProvider],
-    ['imports', resolve],
-    ['exports', resolve],
-  ];
+  const cachePipe = ngMocksUniverse.flags.has('cachePipe');
+  if (!cachePipe) {
+    ngMocksUniverse.flags.add('cachePipe');
+  }
   for (const [key, callback] of keys) {
     if (ngModule[key]?.length) {
       mockModuleDef[key] = flatToExisting(ngModule[key], callback);
     }
   }
+  if (!cachePipe) {
+    ngMocksUniverse.flags.delete('cachePipe');
+  }
 
   return mockModuleDef;
 };

lib/mock-service/mock-provider.ts

@@ -63,7 +63,7 @@ const createClassProvider = (provider: any, provide: any) =>
     ? provider
     : helperUseFactory(provide, () => MockService(provider.useClass));
 
-const createMockProvider = (provider: any, provide: any, cacheProviders: Map<any, any>): Provider | undefined => {
+const createMockProvider = (provider: any, provide: any, cacheProviders?: Map<any, any>): Provider | undefined => {
   let mockProvider: Provider | undefined;
   if (typeof provide === 'function') {
     mockProvider = createFactoryProvider(provider, provide);

tests/get-mocked-ng-def-of/test.spec.ts

@@ -43,12 +43,6 @@ class TargetDirective {}
 class TargetModule {}
 
 describe('getMockedNgDefOf:legacy', () => {
-  it('returns mock for a module', () => {
-    const mock = MockModule(TargetModule);
-    expect(getMockedNgDefOf(TargetModule, 'm')).toBe(mock);
-    expect(getMockedNgDefOf(TargetModule)).toBe(mock);
-  });
-
   it('returns mock for a component', () => {
     const mock = MockComponent(TargetComponent);
     expect(getMockedNgDefOf(TargetComponent, 'c')).toBe(mock);
@@ -70,6 +64,12 @@ describe('getMockedNgDefOf:legacy', () => {
       /There is no mock for TargetPipe/,
     );
   });
+
+  it('returns mock for a module', () => {
+    const mock = MockModule(TargetModule);
+    expect(getMockedNgDefOf(TargetModule, 'm')).toBe(mock);
+    expect(getMockedNgDefOf(TargetModule)).toBe(mock);
+  });
 });
 
 describe('getMockedNgDefOf:mocks', () => {

tests/issue-241/fixtures.ts

@@ -0,0 +1,35 @@
+import { Component, NgModule, Pipe, PipeTransform } from '@angular/core';
+
+@Pipe({
+  name: 'target',
+})
+export class TargetPipe implements PipeTransform {
+  public transform(value: string): string {
+    return `${value.length}`;
+  }
+}
+
+@NgModule({
+  declarations: [TargetPipe],
+  exports: [TargetPipe],
+})
+export class PipeModule {}
+
+@NgModule({
+  exports: [TargetPipe],
+  imports: [PipeModule],
+})
+export class TargetModule {}
+
+@Component({
+  selector: 'target',
+  template: `{{ 'target' | target }}`,
+})
+export class TargetComponent {}
+
+@NgModule({
+  declarations: [TargetComponent],
+  exports: [TargetComponent],
+  imports: [TargetModule],
+})
+export class AppModule {}

tests/issue-241/test.builder.spec.ts

@@ -0,0 +1,16 @@
+import { MockBuilder, MockRender } from 'ng-mocks';
+
+import { AppModule, TargetComponent } from './fixtures';
+
+describe('issue-241:builder', () => {
+  beforeEach(() => MockBuilder(TargetComponent, AppModule));
+
+  it('it exports pipe', () => {
+    const fixture = MockRender(TargetComponent);
+
+    // A mock pipe returns nothing.
+    expect(fixture.nativeElement.innerHTML).toEqual(
+      '<target></target>',
+    );
+  });
+});

tests/issue-241/test.classic.spec.ts

@@ -0,0 +1,21 @@
+import { TestBed } from '@angular/core/testing';
+import { MockModule, MockRender } from 'ng-mocks';
+
+import { AppModule, TargetComponent } from './fixtures';
+
+describe('issue-241:classic', () => {
+  beforeEach(() =>
+    TestBed.configureTestingModule({
+      imports: [MockModule(AppModule)],
+    }).compileComponents(),
+  );
+
+  it('it exports pipe', () => {
+    const fixture = MockRender(TargetComponent);
+
+    // A mock pipe returns nothing.
+    expect(fixture.nativeElement.innerHTML).toEqual(
+      '<target></target>',
+    );
+  });
+});

tests/issue-241/test.guts.spec.ts

@@ -0,0 +1,21 @@
+import { TestBed } from '@angular/core/testing';
+import { MockRender, ngMocks } from 'ng-mocks';
+
+import { AppModule, TargetComponent } from './fixtures';
+
+describe('issue-241:guts', () => {
+  beforeEach(() =>
+    TestBed.configureTestingModule(
+      ngMocks.guts(TargetComponent, AppModule),
+    ).compileComponents(),
+  );
+
+  it('it exports pipe', () => {
+    const fixture = MockRender(TargetComponent);
+
+    // A mock pipe returns nothing.
+    expect(fixture.nativeElement.innerHTML).toEqual(
+      '<target></target>',
+    );
+  });
+});

tests/issue-241/test.real.spec.ts

@@ -0,0 +1,21 @@
+import { TestBed } from '@angular/core/testing';
+import { MockRender } from 'ng-mocks';
+
+import { AppModule, TargetComponent } from './fixtures';
+
+describe('issue-241:real', () => {
+  beforeEach(() =>
+    TestBed.configureTestingModule({
+      imports: [AppModule],
+    }).compileComponents(),
+  );
+
+  it('it exports pipe', () => {
+    const fixture = MockRender(TargetComponent);
+
+    // A real pipe returns the string's length.
+    expect(fixture.nativeElement.innerHTML).toEqual(
+      '<target>6</target>',
+    );
+  });
+});