Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: MockBuilder ignores originally provided mock service #3265

Closed
satanTime opened this issue Aug 5, 2022 · 1 comment · Fixed by #3271
Closed

Bug: MockBuilder ignores originally provided mock service #3265

satanTime opened this issue Aug 5, 2022 · 1 comment · Fixed by #3271
Assignees
@satanTime
Labels
bug Something isn't working released v14.1.2

Comments

@satanTime
Copy link
Member

Description of the bug

MockBuilder(ServiceToTest, SomeService).mock(SomeService) shouldn't throw an error.

An example of the bug

Link: https://codesandbox.io/s/vibrant-mclaren-yw2j29
@satanTime satanTime added the bug Something isn't working label Aug 5, 2022
@satanTime satanTime self-assigned this Aug 5, 2022
satanTime added a commit to satanTime/ng-mocks that referenced this issue Aug 7, 2022
@satanTime
fix(MockBuilder): respects initial config of declarations help-me-mom…
a488563 
…#3265
@satanTime satanTime mentioned this issue Aug 7, 2022
Merged
satanTime added a commit to satanTime/ng-mocks that referenced this issue Aug 7, 2022
@satanTime
fix(MockBuilder): respects initial config of declarations help-me-mom…
1bea651 
…#3265
@satanTime
Copy link
Member Author

v14.1.2 has been released and contains a fix for the issue. Feel free to reopen the issue or to submit a new one if you meet any problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@satanTime satanTime

Labels
bug Something isn't working released v14.1.2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(MockBuilder): respects initial config of declarations #3265 satanTime/ng-mocks
1 participant
@satanTime