Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Any negative value except for -1 is incorrectly accepted as the key #2

Closed
michimune opened this issue May 12, 2020 · 1 comment · Fixed by #4
Closed

Any negative value except for -1 is incorrectly accepted as the key #2

michimune opened this issue May 12, 2020 · 1 comment · Fixed by #4

Comments

@michimune
Copy link

cs50/caesar/caesar.c

Line 17 in 6176a97

if (key == -1)

If you specify a negative number but -1, the code returns an unexpected result. It should display an error message when a negative value is specified as the key.

Example:
$ ./caeser -10
plaintext: abcdefgABCDEFG
ciphertext:WXYZ[]789:;<=
@michimune michimune mentioned this issue May 12, 2020
Closed
@ikeay
Copy link
Owner

ikeay commented May 14, 2020

Thanks! It is bug. It will correct when merging this pull request :)
#4

@ikeay ikeay linked a pull request May 16, 2020 that will close this issue
Review azarashin #4
Merged
@ikeay ikeay closed this as completed in #4 May 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Review azarashin azarashin/cs50
2 participants
@ikeay @michimune