Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Under-the-hood refactoring #30

Open
jmarkovic opened this issue Mar 3, 2016 · 0 comments
Open

Under-the-hood refactoring #30

jmarkovic opened this issue Mar 3, 2016 · 0 comments
Assignees

Comments

@jmarkovic
Copy link
Collaborator

While introducing the last PR ( #29 ), I've noticed that some classes keep a reference to the Context. This may be an undesirable since it only might be useful for initialisation.

I propose that the part that initialises typefaces is moved to MagicViews class and that MagicFonts remains the point where typefaces live and keep their references without any Context reference.

I'm willing to do this work, but would need to discuss every change as this may be a major release (if we choose to remove deprecated methods). Would you like future PRs to go to development branch or a new branch just for this?

@jmarkovic jmarkovic self-assigned this Apr 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant