New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Catch small bin_size parameters #43

Closed

timmeinhardt opened this issue Dec 20, 2017 · 1 comment

Contributor

timmeinhardt commented Dec 20, 2017

This part of the visualization https://github.com/ikostrikov/pytorch-a2c-ppo-acktr/blob/163f0199a89339711ba09ce28420b554f6bf024d/visualize.py#L19 breaks if the bin_size is not at least 3. Maybe catch small bin sizes with an assert?

Owner

ikostrikov commented Dec 27, 2017 •

edited

Hi!

Sorry, I've just noticed the issue.

Yes, it looks like a bug but it should be caught by a try ... catch block in the main file.

ikostrikov closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment