Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why do you input grad & params into metaoptimizer? #6

Closed
ethancaballero opened this issue Apr 14, 2018 · 1 comment
Closed

Why do you input grad & params into metaoptimizer? #6

ethancaballero opened this issue Apr 14, 2018 · 1 comment

Comments

@ethancaballero
Copy link

In line 81 & 135 of meta_optimizer.py
Why do you input grads & params (and loss as well in line 135) into metaoptimizer?

Did you try with & without, and one version worked better? In 1606.04474, they seem to just input grads into metaoptimizer.

@ikostrikov
Copy link
Owner

Hi @ethancaballero, I was hard to reproduce results from meta optimizer papers so at some point I just gave up and shared this code just as an example of how it can be implemented in PyTorch.

Meta optimizers are very slow so I didn't validate any design decisions properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants