Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

merge changes from phantomjs #1

Open
glensc opened this issue Oct 2, 2016 · 1 comment
Open

merge changes from phantomjs #1

glensc opened this issue Oct 2, 2016 · 1 comment

Comments

@glensc
Copy link

glensc commented Oct 2, 2016

https://github.com/ariya/phantomjs/tree/master/src/qcommandline

perhaps cherry-pick useful commits from there,
as i see you bumped version to allow api incompatibilities: 4dbfea9
should be safe to break anything :)
@iksaif
Copy link
Owner

iksaif commented Oct 2, 2016

If somebody from phantomjs wants to send back patches that would be great :) I'm honestly amazed that somebody ended up using this code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@glensc @iksaif