Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect handling of status code 30 #199

Closed
Sgiath opened this issue Mar 7, 2021 · 4 comments
Closed

Incorrect handling of status code 30 #199

Sgiath opened this issue Mar 7, 2021 · 4 comments
Labels
bug Something isn't working gemini-protocol This issue is related to the gemini protocol

Comments

@Sgiath
Copy link

Sgiath commented Mar 7, 2021

When server sends response: 30 /\r\n the browser should redirect to home page of the server but Kristall instead shows "Protocol Violation" page with error code "Line is too short for valid protocol".

I believe this response is valid one since status code 30 allows returning relative paths. Other Gemini browsers (for example Amfora) handle this response correctly.

@Sgiath Sgiath changed the title Incorrect handling of 30 status code Incorrect handling of status code 30 Mar 7, 2021
@ikskuh ikskuh added the bug Something isn't working label Mar 7, 2021
@ikskuh
Copy link
Owner

ikskuh commented Mar 7, 2021

I cannot reproduce this locally:

echo -ne '30 /\r\n' | ncat --listen --ssl --ssl-cert cert.pem --ssl-key key.pem  1965
echo -ne '20 text/plain\r\nsuccess' | ncat --listen --ssl --ssl-cert cert.pem --ssl-key key.pem  1965

It works and properly redirects. Which version of Kristall are you using?

@ikskuh ikskuh added the gemini-protocol This issue is related to the gemini protocol label Mar 7, 2021
@Sgiath
Copy link
Author

Sgiath commented Mar 7, 2021

I am using version 0.3-0 from Arch Linux AUR repository and I can reproduce it locally with your commands.

@ikskuh
Copy link
Owner

ikskuh commented Mar 7, 2021

Ah yeah. 0.3.0 is outdated by nearly a year and roughly 400 commits. You should use the nightly download or build it yourself

@ikskuh ikskuh closed this as completed Mar 8, 2021
@Sgiath
Copy link
Author

Sgiath commented Mar 8, 2021

Oh I didn't realized that. Sorry for wasting your time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working gemini-protocol This issue is related to the gemini protocol
Projects
None yet
Development

No branches or pull requests

2 participants