New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Map instead of Object for caching #27

Open

atfera opened this issue Feb 16, 2023 · 0 comments · May be fixed by #43

Labels

Collaborator

atfera commented Feb 16, 2023 •

edited

Loading

Map is probably better optimised than object for caching purpose.
Plus we can have a custom Map that handle jsMol delete directly:

class MolCache extends Map {
  delete(smiles) {
    const mol = this.get(smiles)
    mol?.delete()
    return super.delete(smiles);
  }
  
  clear() {
   // same, handle jsmol delete
  } 
}

atfera added the enhancement label

RamziWeslati added a commit that referenced this issue


          ref(cache): use Map instead of object to store JSMol cache

21ab24a

See #27

RamziWeslati linked a pull request

that will close this issue

ref(cache): use Map instead of object to store JSMol cache #43

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment