Require Python 3.8+ to install #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without the `python_requires` metadata, the version check does nothing at all when installed from a bdist from e.g. PyPI. After shipping this new version, you may want to "yank" older releases so that naive install commands on older Pythons get an explicit error rather than an incompatible package.
|
Thanks! I am not sure I will have time to upload the new version soon however. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without the
python_requiresmetadata, the version check does nothing at all when installed from a bdist from e.g. PyPI. After shipping this new version, you may want to "yank" older releases so that naive install commands on older Pythons get an explicit error rather than an incompatible package.Prompted by my debugging this exact issue when using
com2annon Hypothesis, then planning to build it intoshed --refactorand realising that I couldn't rely on importable == usable.