Fix for Python 3.9+. #66
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes <ilevkivskyi#60>. Based on an idea in ilevkivskyi#60 (comment).
|
Not sure if that's the most correct fix (probably not, I haven't spent much time on it), but it at least allows the test suite to pass. |
jstasiak
reviewed
Jan 15, 2021
| @@ -75,7 +75,7 @@ def is_generic_type(tp): | |||
| """ | |||
| if NEW_TYPING: | |||
| return (isinstance(tp, type) and issubclass(tp, Generic) or | |||
| isinstance(tp, _GenericAlias) and | |||
| (isinstance(tp, _GenericAlias) or isinstance(tp, _SpecialGenericAlias)) and | |||
There was a problem hiding this comment.
Just a note: isinstance accepts tuples of types and isinstance(tp, (_GenericAlias, _SpecialGenericAlias)) could be easier to read.
ilevkivskyi
reviewed
Jan 17, 2021
There was a problem hiding this comment.
Thanks! Few comments:
- Please use a tuple of types in
isinstance()as @jstasiak suggested. - You should import
_SpecialGenericAliasconditionally on Python version, otherwise tests will fail on other Python versions. - There are dozen other places in the module where
_GenericAliasis used, should they also be updated? - It looks like this only change in itself is not sufficient to fix test failures on Python 3.9, as you can see from a build I started, there is also some error about TypedDict keys.
Weird! Perhaps because I used the last 0.6.0 PyPI archive instead of the latest commit? Here it gave: The package definition I used in Guix reads as: (define-public python-typing-inspect
(package
(name "python-typing-inspect")
(version "0.6.0")
(source (origin
(method url-fetch)
(uri (pypi-uri "typing_inspect" version))
(sha256
(base32
"1dzs9a1pr23dhbvmnvms2jv7l7jk26023g5ysf0zvnq8b791s6wg"))
(patches (search-patches "python-typing-inspect-fix.patch"))))
(build-system python-build-system)
(propagated-inputs
`(("python-mypy-extensions" ,python-mypy-extensions)
("python-typing-extensions" ,python-typing-extensions)))
(home-page "https://github.com/ilevkivskyi/typing_inspect")
(synopsis "API for inspection of types in the Python @code{typing} module")
(description
"The @code{typing_inspect} module defines experimental API for runtime
inspection of types defined in the Python standard typing module.")
(license license:expat)))As you can see if fetches its sources from the PyPI release 0.6.0 release. |
|
Answering myself: yes, this patch fixes the issues when using the last release 0.6.0, but is not sufficient for what's in master ( |
|
This patch makes build for Python < 3.9 fail for me. |
ilevkivskyi
pushed a commit
that referenced
this pull request
Mar 21, 2021
|
@Apteryks Sorry, closing this in favor of the other PRs, thanks for your attempt! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #60.
Based on an idea in
#60 (comment).