Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove soft delete as a concept #1085

Closed
jrjohnson opened this issue Nov 3, 2015 · 2 comments
Closed

Remove soft delete as a concept #1085

jrjohnson opened this issue Nov 3, 2015 · 2 comments
Assignees
@stopfstedt
Milestone
v3.0.0-final

Comments

@jrjohnson
Copy link
Member

Soft delete is partially implemented and not really a protection against anything but the most lucky of circumstances. As a result we should remove soft deletes where they exist and rely on database backup / rollback to deal with. Those things which are currently being soft-deleted should be deleted instead and cascading used to remove relationships.
@jrjohnson jrjohnson added this to the v3.0.0-final milestone Nov 3, 2015
@jrjohnson
Copy link
Member Author

Thought: We could prevent deletes of important things like courses / programs / schools be instead NOT cascading deletes so any delete action would fail on a database level in those cases where a course had sessions for example.

@stopfstedt
Copy link
Member

^ agreed. cascading deletes are prohibited via the fkey constraints already.

since soft deletes have been removed via #1087 i'm gonna close this one out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stopfstedt stopfstedt

Labels
None yet
Projects
None yet
Milestone
v3.0.0-final
Development

No branches or pull requests
2 participants
@jrjohnson @stopfstedt