Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Errors reporting to google should not cause request to fail #1689

Closed
jrjohnson opened this issue Dec 6, 2016 · 0 comments · Fixed by #1690
Closed

Errors reporting to google should not cause request to fail #1689

jrjohnson opened this issue Dec 6, 2016 · 0 comments · Fixed by #1690
Assignees
@stopfstedt
Labels
BUG

Comments

@jrjohnson
Copy link
Member

Currently if analytics don't go through a PUT or POST request will send out a 500 error and show a failure. These should probably die silently and be logged.

Eg:

Uncaught PHP Exception Http\Client\Exception\NetworkException: "cURL error 7: Failed to connect to
  www.google-analytics.com port 80: Operation timed out (see
  http://curl.haxx.se/libcurl/c/libcurl-errors.html)" at
  /Users/jrjohnson/Documents/projects/ilios/api/vendor/php-http/guzzle6-adapter/src/Promise.php line
  121
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stopfstedt stopfstedt

Labels
BUG
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

catch and log tracking exceptions.
2 participants
@jrjohnson @stopfstedt