Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean up db schema install scripts #212

Closed
stopfstedt opened this issue Oct 1, 2013 · 0 comments
Closed

clean up db schema install scripts #212

stopfstedt opened this issue Oct 1, 2013 · 0 comments

Comments

@stopfstedt
Copy link
Member

database/install/ilios_tables.sql is a mess.

TODO:

  • convert tabs to white space
  • indent everything properly (4 spaces per indentation level) and align the beginning of each SQL statement with the left margin.
  • lose the following statements and fragments:
    • SET auto_increment=1
    • SET character_set_client = utf8;
    • any table comments ( NOT the doc blocks above each CREATE TABLE statement, just the COMMENT='...' on the table itself)
  • apply proper quotes to table collation, table engine, default charset etc values.
  • add DROP TABLE IF EXISTS statements before each CREATE TABLE statement where missing.
  • remove any obsolete commented out code.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants