Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

user event link throws error #4344

Closed
saschaben opened this issue May 2, 2017 · 5 comments · Fixed by ilios/common#3498
Closed

user event link throws error #4344

saschaben opened this issue May 2, 2017 · 5 comments · Fixed by ilios/common#3498
Assignees
Labels
BUG UI User Facing Interface Issue
Projects

Comments

@saschaben
Copy link
Member

saschaben commented May 2, 2017

if a permalink for a user event is accessed by someone who is not the original user, or who does not have a direct association like the original user, it will throw an error.

EX: on UCSF stage, the link https://ilios-stage.ucsf.edu/events/U20170501O94257 is only accessible to those learners in the B1 group; however we don't provide any info on the error to explain this. The "public" event link for this event would be https://ilios-stage.ucsf.edu/events/S0120170501O94257.

Ideally, we should find a way to inform & redirect users to the proper link for public viewing of events.

@jrjohnson jrjohnson added the BUG label May 2, 2017
@jrjohnson
Copy link
Member

There really isn't any way to get from the user link to the school link. Neither are technically 'public' but the schools link is at least accessible for everyone in the school.

We can, for sure, at least put up a nice 404 error and not the error garbage that is there currently.

@jrjohnson
Copy link
Member

On third thought - after taking a look we can get from our hash to an offering.
Something like U20170501O94257 does cary the offering ID with it. We just need to parse and extract and then go to the API for more data. So an error message which contains a good link is doable for sure.

@dartajax
Copy link
Member

need a specific 404 error page for users

@jrjohnson jrjohnson transferred this issue from ilios/frontend Aug 25, 2022
@jrjohnson jrjohnson added the UI User Facing Interface Issue label Aug 25, 2022
@stopfstedt stopfstedt self-assigned this Aug 14, 2023
@stopfstedt
Copy link
Member

i wired up a new route missing-user-event, which gets the slug of the originally requested user event as input.
for additional context, we also have access to the currently logged in user.

however, we can't tell why the event was "not found" - whether it was b/c of missing permissions b/c of user mismatch, or because the event itself is gone.

here's a screenshot of the the page that the user gets redirected to, with some placeholder text.

image

@saschaben - what should the actual messaging be?

@saschaben
Copy link
Member Author

I'm thinking maybe:

Event Not Found

The event you have tried to reach is either no longer available, or you have followed a personalized user link which is not shareable. If you continue to encounter issues, please contact your Ilios help desk.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BUG UI User Facing Interface Issue
Projects
No open projects
Ilios
  
Backlog
Development

Successfully merging a pull request may close this issue.

4 participants