Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

behat step tweaks #457

Closed
Trott opened this issue Feb 13, 2014 · 5 comments
Closed

behat step tweaks #457

Trott opened this issue Feb 13, 2014 · 5 comments
Assignees
Milestone

Comments

@Trott
Copy link
Contributor

Trott commented Feb 13, 2014

Things like this:

Given I am on the Ilios home page                                        
When I go to "/ilios.php/dashboard_controller" 

Should probably be more like:

Given I am on the Ilios home page
And I click on "Whatever"

Basically, I'm assigning myself a ticket to go through and do some copyediting.

@Trott Trott self-assigned this Feb 13, 2014
@saschaben saschaben added this to the v2.4.1 milestone Feb 18, 2014
@saschaben saschaben modified the milestones: v2.4.2, v2.4.1 Apr 4, 2014
@jrjohnson
Copy link
Member

Just a note that the top navigation tabs have dedicated

When I navigate to the "Programs" tab

language.

@Trott
Copy link
Contributor Author

Trott commented Apr 16, 2014

Looks like I did that right around the time I opened this ticket.

$ git blame learner_group.feature
...
bf6a1645 (Rich Trott       2014-02-20 13:43:39 -0800 15)     When I navigate to the "Programs" tab

Guess I should have added a comment here...

@Trott
Copy link
Contributor Author

Trott commented Apr 16, 2014

Looks like the only place that language currently survives is in authentication.feature.

$ grep 'When I go to' *
authentication.feature:    When I go to "/ilios.php/dashboard_controller"
authentication.feature:    When I go to "/ilios.php/dashboard_controller"

@Trott
Copy link
Contributor Author

Trott commented Apr 16, 2014

And it looks like it can be replaced with When I navigate to the "Home" tab which may have been your original point...

@Trott
Copy link
Contributor Author

Trott commented Apr 16, 2014

Actually, those two tests that are left are tests for what happens when you, you know, go to the URL, like if it was bookmarked. So they're fine. I'm closing this. As much as I'm enjoying this extended conversation with myself, all things must pass, like kidney stones.

@Trott Trott closed this as completed Apr 16, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants