consolidate owningSchool, primarySchool and school

[stopfstedt]

this will allow us to pull school-getter/setters out into a dedicated interface and trait.

the an create entity "school" comparator that will come in very handy with the access voters.

[stopfstedt]

$ egrep -ril 'owningschool|owning_school' src | sort -u
src/Ilios/AuthenticationBundle/Voter/CourseVoter.php
src/Ilios/AuthenticationBundle/Voter/CurriculumInventoryExportVoter.php
src/Ilios/AuthenticationBundle/Voter/CurriculumInventoryReportVoter.php
src/Ilios/AuthenticationBundle/Voter/DisciplineVoter.php
src/Ilios/AuthenticationBundle/Voter/LearnerGroupVoter.php
src/Ilios/AuthenticationBundle/Voter/ObjectiveVoter.php
src/Ilios/AuthenticationBundle/Voter/ProgramVoter.php
src/Ilios/AuthenticationBundle/Voter/ProgramYearStewardVoter.php
src/Ilios/AuthenticationBundle/Voter/ProgramYearVoter.php
src/Ilios/AuthenticationBundle/Voter/PublishEventVoter.php
src/Ilios/AuthenticationBundle/Voter/SchooleventVoter.php
src/Ilios/AuthenticationBundle/Voter/SessionTypeVoter.php
src/Ilios/CoreBundle/Entity/Competency.php
src/Ilios/CoreBundle/Entity/CourseInterface.php
src/Ilios/CoreBundle/Entity/Course.php
src/Ilios/CoreBundle/Entity/DisciplineInterface.php
src/Ilios/CoreBundle/Entity/Discipline.php
src/Ilios/CoreBundle/Entity/ProgramInterface.php
src/Ilios/CoreBundle/Entity/Program.php
src/Ilios/CoreBundle/Entity/School.php
src/Ilios/CoreBundle/Entity/SessionTypeInterface.php
src/Ilios/CoreBundle/Entity/SessionType.php
src/Ilios/CoreBundle/Form/Type/CourseType.php
src/Ilios/CoreBundle/Form/Type/DisciplineType.php
src/Ilios/CoreBundle/Form/Type/ProgramType.php
src/Ilios/CoreBundle/Form/Type/SessionTypeType.php
src/Ilios/CoreBundle/Tests/DataLoader/CourseData.php
src/Ilios/CoreBundle/Tests/DataLoader/DisciplineData.php
src/Ilios/CoreBundle/Tests/DataLoader/ProgramData.php
src/Ilios/CoreBundle/Tests/DataLoader/SessionTypeData.php
src/Ilios/CoreBundle/Tests/Entity/CourseTest.php
src/Ilios/CoreBundle/Tests/Entity/DisciplineTest.php
src/Ilios/CoreBundle/Tests/Entity/ProgramTest.php
src/Ilios/CoreBundle/Tests/Fixture/LoadCourseData.php
src/Ilios/CoreBundle/Tests/Fixture/LoadDisciplineData.php
src/Ilios/CoreBundle/Tests/Fixture/LoadProgramData.php
src/Ilios/CoreBundle/Tests/Fixture/LoadSessionTypeData.php

$ egrep -ril 'owningschool|owning_school' app | sort -u
app/Resources/DoctrineMigrations/Version20150805000000.php
app/Resources/updateSchemaFromIlios2toIlios3.sql

[stopfstedt]

come to think of it, user::primary_school is just another variation of this. consolidate!

$ egrep -irl 'primary_school|primaryschool' src | sort -n
src/Ilios/AuthenticationBundle/Voter/CompetencyVoter.php
src/Ilios/AuthenticationBundle/Voter/CourseVoter.php
src/Ilios/AuthenticationBundle/Voter/CurriculumInventoryExportVoter.php
src/Ilios/AuthenticationBundle/Voter/CurriculumInventoryInstitutionVoter.php
src/Ilios/AuthenticationBundle/Voter/CurriculumInventoryReportVoter.php
src/Ilios/AuthenticationBundle/Voter/DepartmentVoter.php
src/Ilios/AuthenticationBundle/Voter/DisciplineVoter.php
src/Ilios/AuthenticationBundle/Voter/InstructorGroupVoter.php
src/Ilios/AuthenticationBundle/Voter/LearnerGroupVoter.php
src/Ilios/AuthenticationBundle/Voter/LearningMaterialVoter.php
src/Ilios/AuthenticationBundle/Voter/ObjectiveVoter.php
src/Ilios/AuthenticationBundle/Voter/ProgramVoter.php
src/Ilios/AuthenticationBundle/Voter/ProgramYearStewardVoter.php
src/Ilios/AuthenticationBundle/Voter/ProgramYearVoter.php
src/Ilios/AuthenticationBundle/Voter/PublishEventVoter.php
src/Ilios/AuthenticationBundle/Voter/SchooleventVoter.php
src/Ilios/AuthenticationBundle/Voter/SchoolVoter.php
src/Ilios/AuthenticationBundle/Voter/SessionTypeVoter.php
src/Ilios/AuthenticationBundle/Voter/UserVoter.php
src/Ilios/CoreBundle/Entity/UserInterface.php
src/Ilios/CoreBundle/Entity/User.php
src/Ilios/CoreBundle/Form/Type/UserType.php
src/Ilios/CoreBundle/Tests/DataLoader/UserData.php
src/Ilios/CoreBundle/Tests/Entity/UserTest.php
src/Ilios/CoreBundle/Tests/Fixture/LoadUserData.php

$ egrep -irl 'primary_school|primaryschool' app | sort -n
app/Resources/DoctrineMigrations/Version20150805000000.php
app/Resources/updateSchemaFromIlios2toIlios3.sql

[ctam]

I think we had discussed this before, but just want to confirm. I assume this will go into API v2, correct? It's not going to affect API v1. And there will be a period (6 month, maybe) that both would be available before you deprecate v1. Am I right?

[jrjohnson]

@ctam - we haven't finalized v1 yet. So this would go into v1. Until we release a final v1 it should be considered in flux. Once we lock down a final v1 version then we would keep it in production for a min of 6 months and provide an upgrade path to v2.

[ctam]

👎 Make sure you guys coordinate with us (CLE) when you guys release this on production (and staging, too as of the current arrangement).

[saschaben]

@ctam maintaining stability for the new enrolment plugin and other systems calling the API to support UCSF students is a key priority for us; we will certainly coordinate when there are changes that might impact associated systems or require modifications.