Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-package tensorflow-serving-api==1.9.0 (discussion about future of this package) #6

Closed
illagrenan opened this issue Jul 9, 2018 · 12 comments

Comments

@illagrenan
Copy link
Owner

Release: https://pypi.org/project/tensorflow-serving-api/1.9.0rc2/

@ghego
Copy link

ghego commented Aug 1, 2018

1.9.0 has been out for a while. Is this going to be repackaged?

@illagrenan
Copy link
Owner Author

I will try to release a new version later today (Thu) or tomorrow (Fri).

@ghego
Copy link

ghego commented Aug 1, 2018

actually, I was just checking the official package and it seems to be supporting py3 too. have a look: https://pypi.org/project/tensorflow-serving-api/#files

@illagrenan
Copy link
Owner Author

You're right! That's new. So I think my project is no longer needed. 😄 It looks like tensorflow-serving-api supports Python 3 from version >=1.8.0.

@ghego
Copy link

ghego commented Aug 1, 2018

as far as I understand they did release it with tf 1.9 but somehow the tensorflow_model_server command is not available. I'm confused..

@ghego
Copy link

ghego commented Aug 1, 2018

My bad, I needed to update the linux package too. https://www.tensorflow.org/serving/setup#aptget

@spate141
Copy link

spate141 commented Aug 2, 2018

@illagrenan Thank you for all your work! 🎉

@ghego
Copy link

ghego commented Aug 2, 2018

The official package seems to require tensorflow and does not work with tensorflow-gpu. @illagrenan thanks for the good work! maybe worth keeping this alive for one more release while they fix the issue?

@illagrenan
Copy link
Owner Author

illagrenan commented Aug 2, 2018

@ghego I understand the problem. I have never understood the splitting of the GPU and the non-GPU version of Tensorflow.

You can try this:

pip install 'tensorflow-serving-api~=1.9.0' --no-dependencies
pip install 'tensorflow-gpu~=1.9.0'

@illagrenan illagrenan reopened this Aug 2, 2018
@ghego
Copy link

ghego commented Aug 2, 2018

Thanks that solved the issue. Do you know if it can be done in a requirements file or conda environment.yml ? I don't seem to have found a way to do that.

@illagrenan
Copy link
Owner Author

Unfortunately, it looks like it is not possible in requirements.txt. And I'm not familiar with Conda. 😞 Ref: https://stackoverflow.com/questions/31798280/pass-no-deps-in-pip-requirements-txt

@illagrenan
Copy link
Owner Author

But it shouldn't be so hard to handle this situation with your build script / Dockerfile. For example, I would do this in Dockerfile:

RUN pip install -r requirements.txt
RUN pip uninstall tensorflow-gpu
RUN pip install tensorflow

@illagrenan illagrenan changed the title Re-package tensorflow-serving-api==1.9.0 Re-package tensorflow-serving-api==1.9.0 (discussion about future of this package) Aug 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants