Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Automatic Theme based on light/dark mode in OS #51

Open
1 task done
arimal199 opened this issue Dec 24, 2022 · 4 comments
Open
1 task done

[Feature]: Automatic Theme based on light/dark mode in OS #51

arimal199 opened this issue Dec 24, 2022 · 4 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@arimal199
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Is your feature request related to a problem? Please describe.

No response

Describe your idea or feature request

No response

Describe alternatives you've considered

No response

Anything else?

No response

@arimal199 arimal199 added the enhancement New feature or request label Dec 24, 2022
@bigplayer-ai
Copy link

bigplayer-ai commented Jan 16, 2023

This is a must feature, But I think it should follow VSCODE theme and not OS theme:

switch vibrancy to light mode+ when VScode theme is switched.
or dark mode+ when VScode theme is switched.
All based on VScode theme. 

There is native VSCODE follow OS theme setting, just search theme preferred in settings and enable that feature:
window.autoDetectColorScheme
"window.autoDetectColorScheme": false
image

The only part left for the extension is to adjust itself based on VSCode theme.

@illixion illixion added the help wanted Extra attention is needed label Jan 17, 2023
@bigplayer-ai
Copy link

Hey,
Can you implement this?

@illixion
Copy link
Owner

illixion commented Feb 1, 2023

This isn’t something that I’m personally interested in implementing as I use VSCode exclusively in dark mode, so don’t expect it to be implemented any time soon, but pull requests are always welcome. Perhaps this can be done using a CSS media query and the VSCode setting you’ve mentioned.

@rainbowflesh
Copy link

There was an example https://github.com/danielgjackson/vscode-auto-dark-mode-windows/blob/master/extension.js

I would give a try later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants