Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate IMU/camera Switchboard topics #50

Closed
charmoniumQ opened this issue Jul 26, 2020 · 3 comments
Closed

Separate IMU/camera Switchboard topics #50

charmoniumQ opened this issue Jul 26, 2020 · 3 comments
Labels
design decision Something we need public deliberation on

Comments

@charmoniumQ
Copy link
Member

Or explain why we shouldn't.
This currently complicates the ZED code (where the Camera thread has to send frames to the IMU thread, which pairs them and sends them on a Switchboard topic).
This currently simplifies OpenVINS (where we need to process the camera after the IMU).

@charmoniumQ charmoniumQ created this issue from a note in ILLIXR improvements (Backlog) Jul 26, 2020
@charmoniumQ charmoniumQ added the design decision Something we need public deliberation on label Jul 26, 2020
@mhuzai
Copy link
Member

mhuzai commented Sep 3, 2020

Now that we are integrating scene reconstruction, this issue will come up again. A camera can have multiple consumers, but not all of them may require IMU data. Given our past discussion about visibility, should we have this discussion on gitter?

@astro-friedel astro-friedel linked a pull request Aug 18, 2023 that will close this issue
@astro-friedel
Copy link
Contributor

I believe PR #372 addressed this issue.

@astro-friedel
Copy link
Contributor

This should now be addressed.

ILLIXR improvements automation moved this from Issue Backlog to Done Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design decision Something we need public deliberation on
Projects
Development

Successfully merging a pull request may close this issue.

3 participants