-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SvelteKit support #343
Comments
Hi! Yeah :0 We haven't been at the project for a while, which is why the installation instructions talk about Sapper. The library is compatible with SvelteKit though (it's just Svelte components, after all), and the Reach out if you encounter any issues during setup! |
Thanks for that! I'd like to give this component library a try but I want to make sure that unused components aren't included in the production build. I see that when I install the attractions package all components are installed under node_modules/attraction.s Does svelte take care of not including unused modules behind the scenes using Rollup's default settings (since there is no explicit config setup)? The final bundle size is important for us so I need to be certain that it stays at a minimum. Thanks! |
It's not needed for SvelteKit, just the changes that you'd make in
I'd love to give you full peace of mind, but we haven't actually done full-blown bundle tests. What I do know, however, is that the library mostly contains Also, Attractions is marked as tree-shakeable, if that makes you feel any more confident :) However, if you really need to make a case on tree-shakeability of Attractions (to your coworkers, for example), I'd suggest you to spin up a quick little Svelte project, import one component, check the weight of the build directory, add another import and check again. That's the most reliable way to be sure that you're not shipping anything excess |
Makes sense - thank you. Measuring bundle size before after was on my todo list, was hoping for a straight answer instead of this though. It's an awesome library, but with limited support / unknown future it's hard to win the case of adopting it for prod. Especially that the team is new to Svelte, we don't want to deal with more unknowns :-) Thanks for your quick turnaround! |
Hello!
This is one of the better designed UI component libraries out there so I'd love to use it in prod. However, I don't see explicit mentions of SvelteKit in the documentation and the installation guide mentions Sapper instead.
Is there SvelteKit support?
Are there examples of how to set it up correctly in a SvelteKit project?
Thank you
The text was updated successfully, but these errors were encountered: