Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update installation scripts #677

Merged
merged 2 commits into from
Mar 7, 2022
Merged

Update installation scripts #677

merged 2 commits into from
Mar 7, 2022

Conversation

sbalint98
Copy link
Collaborator

@sbalint98 sbalint98 commented Jan 10, 2022

This PR contains the following changes to the installation scripts:

  • The default LLVM version is set to 11.0.1 Use HIPSYCL_LLVM_DIR to find the LLVM executable and LLVM include paths.
  • The naming problem reported in issue install-llvm.sh doesn't install in the right place #676 has been corrected, now the user needs to set HIPSYCL_INSTALL_PREFIX to control the installation directory instead of INSTALL_PREFIX.
  • In the install-llvm.sh script instead of checking out branches from the LLVM repo tags are used. This allows controlling more precisely the LLVM version.
  • By default the install-hipsycl.sh script installs from the develop branch of the hipSYCL repo
  • During hipSYCL compilation all available cores are used ( make -j nproc` )
  • The LLVM_ENABLE_DUMP and LLVM_TEMPORARILY_ALLOW_OLD_TOOLCHAIN configuration options have been disabled when configuring LLVM

@sbalint98
Copy link
Collaborator Author

@jeffhammond Can you have a look if these changes solve the issue?

@sbalint98 sbalint98 linked an issue Jan 10, 2022 that may be closed by this pull request
@sbalint98 sbalint98 requested a review from illuhad March 6, 2022 23:10
@sbalint98 sbalint98 marked this pull request as ready for review March 6, 2022 23:11
@illuhad illuhad merged commit f82207b into AdaptiveCpp:develop Mar 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

install-llvm.sh doesn't install in the right place
2 participants