Align name mangling in clang 13 host pass with upstream clang and restrict uses of createDeviceMangleContext() #720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…trict uses of createDeviceMangleContext()
|
@hipSYCL-ci-bot test2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the hipSYCL 0.9.2+ name mangling logic for clang 13+, it turns out that we have used
createDeviceMangleContext()too liberally in the host pass. It should only be used when the ABIs are incompatible, and the regular mangler otherwise.The previous code could result in mangling mismatches between host and device in integrated multipass scenarios, which can lead to kernel launch failures.
This PR resolves those issues by replicating the logic that clang itself uses (e.g. in
CGCUDANV.cpp) more closely.Hopefully fixes #718