[cbs] Fix compatibility issues with upstream Clang/LLVM #763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds two missing headers whose contents have been moved in upstream Clang/LLVM. It also changes a call from `PointerType::getElementType()` to `Type::getPointerElementType()` as a temporary fix until opaque pointers are introduced. The former was already deprecated in Clang/LLVM 14 and has been removed in upstream.
|
Fixed commit message. Is actually |
fodinabor
approved these changes
Jul 9, 2022
|
@fodinabor Yes. This only fixes compile-time issues. The clang plugin still fails (unregistered passes or something like that if i remember correctly). I'll create an issue with my findings so far 😊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds two missing headers whose contents have
been moved in upstream Clang/LLVM. It also changes a call
from
PointerType::getElementType()toType::getPointerElementType()as a temporary fixuntil opaque pointers are introduced. The former was already
deprecated in Clang/LLVM 14 and has been removed in upstream.