Avoid printing unprintable from memset_operation::dump #795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since `get_pattern` returns `unsigned char`, it was printed as such. So, for example, when zeroing an array, a NULL byte was printed to stderr in debug mode. Nothing serious, but not very helpful either. Since using `memset` to fill the buffer with repetitions of a printable character is not the most common usecase, now we print the pattern as an integer.
DieGoldeneEnte
pushed a commit
to DieGoldeneEnte/hipSYCL
that referenced
this pull request
Aug 8, 2022
Since `get_pattern` returns `unsigned char`, it was printed as such. So, for example, when zeroing an array, a NULL byte was printed to stderr in debug mode. Nothing serious, but not very helpful either. Since using `memset` to fill the buffer with repetitions of a printable character is not the most common usecase, now we print the pattern as an integer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
get_patternreturnsunsigned char, it was printed as such.So, for example, when zeroing an array, a NULL byte was printed to
stderr in debug mode. Nothing serious, but not very helpful either.
Since using
memsetto fill the buffer with repetitions of a printablecharacter is not the most common usecase, now we print the pattern as an
integer.