Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement sincos and sinh math builtins #802

Merged
merged 1 commit into from
Aug 9, 2022
Merged

Implement sincos and sinh math builtins #802

merged 1 commit into from
Aug 9, 2022

Conversation

nmnobre
Copy link
Member

@nmnobre nmnobre commented Aug 8, 2022

Hi @illuhad,

I had a go at implementing both sincos and sinh.
Since I'm a bit of a C++ noob, how far is this from something you'd be happy with?

Cheers :)

illuhad
illuhad reviewed Aug 8, 2022
View reviewed changes
Copy link
Collaborator

@illuhad illuhad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh, I thought we had those builtins already :D Very surprising that we have cosh, but sinh was missing. Thanks for looking into this, this already looks very good! :)

include/hipSYCL/sycl/libkernel/generic/hiplike/builtins.hpp Show resolved Hide resolved
include/hipSYCL/sycl/libkernel/host/builtins.hpp Show resolved Hide resolved
include/hipSYCL/sycl/libkernel/spirv/builtins.hpp Show resolved Hide resolved
@illuhad illuhad merged commit 598767a into AdaptiveCpp:develop Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@illuhad illuhad illuhad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nmnobre @illuhad