Make embedded_pointer store pointer which than convert to unique_id rather than the other way round #821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rather than the other way round
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
embedded_pointerhas storedunique_idand then reinterpreted the id to pointers inside device code. I believe that this can cause backends to be unable to infer that the address space of the accessor pointer must be global address space, which can have performance impact.This PR swaps the behavior of
embedded_pointer: It now stores pointers, which are reinterpret-casted tounique_idwhen needed. This should help backends infer address space.There is a chance that this fixes #729