Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update comment on nvc++ workaround in mem_fence() #849

Merged
merged 1 commit into from
Oct 20, 2022

Conversation

nmnobre
Copy link
Member

@nmnobre nmnobre commented Oct 12, 2022

Hi @illuhad,

It seems Nvidia has indeed fixed the compiler errors with empty if target statements.
See #767 (happy to close if you are) and #798.

Cheers :)

@nmnobre
Copy link
Member Author

nmnobre commented Oct 13, 2022

On second thought, I think this is overcomplicating things and adds nothing. Besides, it's the wrong place for a fix like this...
I would suggest either:

  1. Adding a note to the comment saying it only applies to versions <= 22.7;
  2. Editing cuda_backend.hpp to add printf(""); or int dummy; (void)dummy; and moving the compiler bug comment there;
  3. Amending the documentation to say we require version 22.9 or newer.

@illuhad
Copy link
Collaborator

illuhad commented Oct 17, 2022

I think it would suffice to just add to the comment that this only affects these older nvc++ versions. We don't need to put in a lot of effort just to be able to express a no-op in an if target path :-)

@nmnobre nmnobre changed the title Update nvc++ workaround in mem_fence() Update comment on nvc++ workaround in mem_fence() Oct 17, 2022
Copy link
Collaborator

@illuhad illuhad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@illuhad illuhad merged commit 012e16d into AdaptiveCpp:develop Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants