Skip to content

Commit

Permalink
175 zfs vdev cache consumes excessive memory
Browse files Browse the repository at this point in the history
Reviewed by: George Wilson <george.wilson@delphix.com>
Reviewed by: Eric Schrock <eric.schrock@delphix.com>
Approved by: Richard Lowe <richlowe@richlowe.net>
  • Loading branch information
Garrett D'Amore committed Apr 22, 2011
1 parent aec2a07 commit b68a40a
Showing 1 changed file with 8 additions and 1 deletion.
9 changes: 8 additions & 1 deletion usr/src/uts/common/fs/zfs/vdev_cache.c
Expand Up @@ -71,9 +71,16 @@
* 1<<zfs_vdev_cache_bshift byte reads by the vdev_cache (aka software
* track buffer). At most zfs_vdev_cache_size bytes will be kept in each
* vdev's vdev_cache.
*
* TODO: Note that with the current ZFS code, it turns out that the
* vdev cache is not helpful, and in some cases actually harmful. It
* is better if we disable this. Once some time has passed, we should
* actually remove this to simplify the code. For now we just disable
* it by setting the zfs_vdev_cache_size to zero. Note that Solaris 11
* has made these same changes.
*/
int zfs_vdev_cache_max = 1<<14; /* 16KB */
int zfs_vdev_cache_size = 10ULL << 20; /* 10MB */
int zfs_vdev_cache_size = 0;
int zfs_vdev_cache_bshift = 16;

#define VCBS (1 << zfs_vdev_cache_bshift) /* 64KB */
Expand Down

0 comments on commit b68a40a

Please sign in to comment.