Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Whenever I open a world, the config files reset #98

Closed
Q01010001 opened this issue Jul 4, 2023 · 8 comments
Closed

[Bug]: Whenever I open a world, the config files reset #98

Q01010001 opened this issue Jul 4, 2023 · 8 comments
Assignees
Labels
status: confirmed This issue or pull request has been accepted type: bug Something isn't working

Comments

@Q01010001
Copy link

Minecraft Version

1.19.2

What happened?

I changed the client config file to have vein mining only when I'm crouching, using all uppercase as is displayed for one of the options, then I hit save and close it. Then when I load into a world, all 3 config files have the current time as when they were last modified and they reset to the defaults. I tried closing the game and relaunching, but that didn't fix the issue. I don't know if I'm doing something wrong to have the configs properly save and load, but I think I'm doing things correctly.

How do you trigger this bug?

  1. Change the config
  2. Save and close
  3. Reload the game and open a world

Loader

Forge

Loader Version

Forge - 43.2.0

API Version

No response

Mod Version

1.1.1 I think. Latest Release as of July 4th

Relevant Log Outputs

No response

@Q01010001 Q01010001 added status: triage This issue or pull request is awaiting review type: bug Something isn't working labels Jul 4, 2023
@TheIllusiveC4 TheIllusiveC4 added status: pending This issue or pull request is pending further information or development and removed status: triage This issue or pull request is awaiting review labels Jul 4, 2023
@TheIllusiveC4
Copy link
Member

I cannot reproduce this, the config saves normally on my end. Please share your config file that you're trying to save, usually resetting means that your syntax is incorrect. Are all of the config files resetting or just the one you changed? If all of them are resetting, please share those config files as well and the values that were changed.

@JaredAI
Copy link

JaredAI commented Jul 9, 2023

This also happens to me.

Go to veinmining-client.toml, select "crouching" for both options, click done and it will work during that session. Exit minecraft, start a new session, and while the config file still shows "crouching" it will vein mine while NOT crouching (it uses the default config). Go back into the config and cycle through the options to again select "crouching" and upon returning to the game it will now act correctly.

@TheIllusiveC4
Copy link
Member

Are you also on 1.19.2? What do you mean by "cycling" through the options? Does it say "CROUCHING" or "crouching"? Are you editing the config file while outside of the game?

@JaredAI
Copy link

JaredAI commented Jul 13, 2023

Are you also on 1.19.2? What do you mean by "cycling" through the options? Does it say "CROUCHING" or "crouching"? Are you editing the config file while outside of the game?

I'm on 1.20 Fabric.

Modmenu has an interface that has 3 options for veinmining:

Veinmining-common.toml
Veinmining-client.toml
Veinmining-server.toml

When clicking on Veinmining-client.toml button it gives you another button with 3 options: STANDING, CROUCHING, HOLD_KEY_DOWN

When CROUCHING is selected, it works until the game is exited and then during a new game it'll revert to the default configuration.

I just edited the Veinmining-client.toml file directly and it works as expected. So maybe this is an issue with modmenu?

@TheIllusiveC4 TheIllusiveC4 added status: confirmed This issue or pull request has been accepted and removed status: pending This issue or pull request is pending further information or development labels Jul 15, 2023
@TheIllusiveC4
Copy link
Member

I just edited the Veinmining-client.toml file directly and it works as expected. So maybe this is an issue with modmenu?

Based on your explanation, I was able to reproduce this issue and I don't believe it's an issue with Mod Menu. I've yet to figure out the cause, but I'll fix this in the next update. Until then, just edit the configuration files directly when needed.

@dit-zy
Copy link

dit-zy commented Jul 23, 2023

This happens to me when I modify the files manually. I tried changing levels to 5 in veinmining-common.toml on my server, but it got reset back to 1 after restarting the server. Then I tried changing maxDistancePerLevel and maxBlocksPerLevel in veinmining-server.toml and the same thing happened after restarting the server again.

@TheIllusiveC4
Copy link
Member

Are you trying to edit the files while the server is running? If so, try and edit them while the server is shutdown.

@dit-zy
Copy link

dit-zy commented Jul 24, 2023

Oh that did resolve my issue editing the files directly. Thank you!

I'm so used to editing the configs live that I forgot that could cause issues for some mods.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: confirmed This issue or pull request has been accepted type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants