Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] add interactivity #1

Open
BachiMjavanadze opened this issue May 30, 2024 · 8 comments
Open

[Feature request] add interactivity #1

BachiMjavanadze opened this issue May 30, 2024 · 8 comments
Assignees
Labels
enhancement New feature or request

Comments

@BachiMjavanadze
Copy link

Please add interactivity to your extension. I mean predefined variables and pass them during call the command. You may grab idea from CommandLauncher (it is abandoned) and implement my issues

@ilmaqui ilmaqui self-assigned this May 31, 2024
@ilmaqui
Copy link
Owner

ilmaqui commented May 31, 2024

Currently working on this, will bring some bug fixes and this feature coming into the next version. Stay tuned!

@BachiMjavanadze
Copy link
Author

BachiMjavanadze commented May 31, 2024

@ilmaqui are you going implement Context menu commands feature too?

@ilmaqui ilmaqui added the enhancement New feature or request label Jun 1, 2024
@ilmaqui
Copy link
Owner

ilmaqui commented Jun 1, 2024

The feature you explained in the first comment is already added in 0.2.0.
As for the second comment, I dont see myself adding this feature for the extension in the near future as it can lead to misunderstandings. What i suggest is adding a more visual command. Lets say you have "cd $route" where $route is basically an inline variable you can pass when running the command. This way we can have an specific type of command that can allow you to run the command directly from the context menu. Even so, this would only allow you to use these specific commands with only one variable, for example: "some-command $route1 $route2" would not work because you wouldnt have $route2 value as you can only select one file via the context menu. Let me know what you think would be the best approach for this or explain further the requested feature. Thank you!

@BachiMjavanadze
Copy link
Author

BachiMjavanadze commented Jun 1, 2024

The feature you explained in the first comment is already added in 0.2.0.

Thanks!

As for the second comment, I dont see myself adding this feature for the extension in the near future as it can lead to misunderstandings.

Misunderstandings?! Why?! You are suggesting compromise but why compromise? The feature already is implemented in Command Runner but it has a little bug: when I click Escape command execution does not stop and creator looks like can't fix it.

@ilmaqui
Copy link
Owner

ilmaqui commented Jun 1, 2024

What I meant with missunderstandings was what you mentioned here. The expandible commands thingy on the quickpick. This itself is a little bit weird and can lead to people oppening bugs as vscode quickpicks doesnt allow expandible groups itself and is not very intuitive. Anyways, I dont see a problem on implementing https://github.com/edonet/vscode-command-runner/issues/64 as i think its a nice feature.

For sure i will add that ${selectedFile} as a reserved name for commands and replace that with the actual selected file path. I just need to look deeper into it. Let me know if you have any other questions / features!

@BachiMjavanadze
Copy link
Author

What I meant with missunderstandings was what you mentioned here. The expandible commands thingy on the quickpick.

I don't understand. I just described how Command Runner works.

Let me know if you have any other questions / features!

I would prefer CommandLauncher UI. It is more

@BachiMjavanadze
Copy link
Author

Now I'm testing your extention. I've created simple command:

image

but can't find it in my settings.json. It should be placed in settings.json for synchronization because if I enter my credentials into another VSCode (on another PC) I want to receive the generated commands rather than having to create them over and over again. also easy to edit commands inside json

@ilmaqui
Copy link
Owner

ilmaqui commented Jun 1, 2024

At the moment im not willing to change the ui the extension has as I think its what goes more for me. Anyways, im planning to add the feature of being able to group commands inside the global, workspace and temporary sub-groupes. So you could have a group of angular commands, a group of react commands etcetera.

but can't find it in my settings.json. It should be placed in settings.json for synchronization because if I enter my credentials into another VSCode (on another PC) I want to receive the generated commands rather than having to create them over and over again. also easy to edit commands inside json

Regarding this, at the moment this is not possible as global commands are store within an unique file for the extension. However, expect this to be in the next release. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants