This repository has been archived by the owner on Apr 19, 2023. It is now read-only.
Update dependencies. #20
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR but the tests are not passing! |
| @@ -24,15 +24,15 @@ | |||
| ], | |||
| "license": "MIT", | |||
| "dependencies": { | |||
| "ejs": "1.0.x", | |||
| "ejs": "^2.2.4", | |||
| "express": "2.5.x", | |||
There was a problem hiding this comment.
I would prefer if we go for x-ranges matching major and minor versions (in this case "ejs": 2.2.x)
|
Any idea why the build failed, but my tests are passing? |
|
Nevermind, I see the build output in the link. =) |
|
That's weird. The build seems to have worked this time, but the Travis integration is still showing a failed build. What's up with that? |
|
Looks to me like the build is passing now, regardless of what GitHub seems to think. =) I'll open a new PR when it's fixed. |
|
Don't merge yet. Tests are passing, but it doesn't seem to actually be working... |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates all dependencies except Express.
All tests pass. Monitor and web UI work.