Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Need help with Korean translation #147

Closed
iluwatar opened this issue Nov 23, 2022 · 2 comments
Closed

Need help with Korean translation #147

iluwatar opened this issue Nov 23, 2022 · 2 comments
Labels
epic:web site info:help wanted type:feature

Comments

@iluwatar
Copy link
Owner

To show the code snippets correctly on the Korean website, we need a translation of README.md. The result of the translation should be placed to localization/ko/README.md.

Acceptance criteria

  • README.md translated to Korean
@iluwatar iluwatar mentioned this issue Nov 23, 2022
Open
@jso4342 jso4342 mentioned this issue Dec 2, 2022
Merged
@jso4342
Copy link
Contributor

jso4342 commented Dec 2, 2022 •
edited

I've created a pull request for translated README.md in Korean!
Hopefully it's helpful :) #148

@iluwatar iluwatar closed this as completed Dec 4, 2022
@iluwatar
Copy link
Owner Author

iluwatar commented Dec 4, 2022

Thank you so much for providing this. It's now available on the website too, see https://java-design-patterns.com/ko/snippets/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
epic:web site info:help wanted type:feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@iluwatar @jso4342