Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some patterns displayed in wrong language #22

Closed
iluwatar opened this issue May 9, 2021 · 6 comments
Closed

Some patterns displayed in wrong language #22

iluwatar opened this issue May 9, 2021 · 6 comments
Assignees
@JackieNim
Labels
info:help wanted Extra attention is needed priority:normal resolution:fixed Further information is requested status:under construction type:bug Something isn't working
Milestone
Java Design Patte...

Comments

@iluwatar
Copy link
Owner

iluwatar commented May 9, 2021

In issue #18 we fixed the patterns showing up more than once, but another problem came up. Some patterns now show in the wrong language e.g. Singleton displayed in Chinese. At the moment we support showing only English versions and the other ones can be filtered out.
@iluwatar iluwatar added type:bug Something isn't working info:help wanted Extra attention is needed priority:normal labels May 9, 2021
@iluwatar iluwatar mentioned this issue May 9, 2021
Closed
@JackieNim JackieNim mentioned this issue May 9, 2021
Closed
@JackieNim
Copy link
Contributor

Look into these PR's for the fix
This should go in first -> iluwatar/java-design-patterns#1750
#24

@iluwatar
Copy link
Owner Author

@JackieNim the PR you mentioned seems to be closed 🤷🏻‍♂️

@iluwatar iluwatar mentioned this issue May 14, 2021
Merged
@JackieNim
Copy link
Contributor

@JackieNim the PR you mentioned seems to be closed 🤷🏻‍♂️

I created iluwatar/java-design-patterns#1752 but seems like he doesnt want to review it again so 🤷

@iluwatar
Copy link
Owner Author

No worries @JackieNim, I think we can reopen it

@iluwatar
Copy link
Owner Author

Merged iluwatar/java-design-patterns#1752

@iluwatar
Copy link
Owner Author

Merged #24

@iluwatar iluwatar added status:under construction resolution:fixed Further information is requested labels May 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JackieNim JackieNim

Labels
info:help wanted Extra attention is needed priority:normal resolution:fixed Further information is requested status:under construction type:bug Something isn't working
Projects
None yet
Milestone
Java Design Pattern Web Site 1.0
Development

No branches or pull requests
2 participants
@iluwatar @JackieNim